Skip to content

feat: add workflow to review PRs labeled with GFI and Beginner#1828

Merged
exploreriii merged 4 commits into
hiero-ledger:mainfrom
tech0priyanshu:feat/GFI_Beginner_triage
Apr 24, 2026
Merged

feat: add workflow to review PRs labeled with GFI and Beginner#1828
exploreriii merged 4 commits into
hiero-ledger:mainfrom
tech0priyanshu:feat/GFI_Beginner_triage

Conversation

@tech0priyanshu

@tech0priyanshu tech0priyanshu commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Description:

Related issue(s): need triage review for pr with GFI and beginner

Fixes #1721

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@tech0priyanshu
tech0priyanshu requested a review from a team as a code owner February 20, 2026 20:05
Copilot AI review requested due to automatic review settings February 20, 2026 20:05
@tech0priyanshu
tech0priyanshu requested a review from a team as a code owner February 20, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub Actions automation intended to involve the triage community when PRs are labeled as beginner/GFI, and documents the change in the changelog.

Changes:

  • Add a new workflow that triggers on PR label events for “Good First Issue” / “Beginner”.
  • Add a changelog entry describing the new workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
CHANGELOG.md Documents the addition of a new PR triage-review workflow.
.github/workflows/request-triage-review.yml Introduces a workflow meant to request triage review based on PR labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread CHANGELOG.md Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
@coderabbitai

coderabbitai Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds a GitHub Actions workflow, a helper script, and a changelog entry to post a triage-request comment on PRs labeled "Good First Issue" or "Beginner" (or run manually). The script reads triage reviewers from a repo file or env, supports dry-run, checks idempotency, and posts comments via the GitHub API.

Changes

Cohort / File(s) Summary
Workflow
.github/workflows/request-triage-review.yml
New GitHub Actions workflow "Request triage review on beginner PRs": triggers on pull_request_target label events and workflow_dispatch, sets concurrency and scoped permissions, and runs a job that invokes the triage-comment script when the PR label is Good First Issue or Beginner.
Script
.github/scripts/bot-pr-gfi-review-triage.sh
New shell script that validates environment variables, extracts the PR number from the event payload, reads triage reviewers from .github/triage-reviewers.txt or TRIAGE_REVIEWERS, enforces idempotency via a marker comment, supports dry-run, and posts a comment to request triage review using the GitHub API (curl + jq).
Changelog
CHANGELOG.md
Adds an "Added" changelog entry documenting the new triage review automation (references issue #1721).

Sequence Diagram(s)

sequenceDiagram
    participant PR as "Pull Request"
    participant Workflow as "GitHub Actions\n(request-triage-review)"
    participant Script as "bot-pr-gfi-review-triage.sh"
    participant TriageList as ".github/triage-reviewers.txt\nor TRIAGE_REVIEWERS"
    participant GitHub as "GitHub API"
    participant Reviewer as "Selected triage member"

    PR->>Workflow: label added ("Good First Issue"/"Beginner") or manual dispatch
    Workflow->>Script: run script (env: GITHUB_EVENT_PATH, GITHUB_TOKEN, GITHUB_REPOSITORY, DRY_RUN)
    Script->>TriageList: read reviewers (file or env)
    Script->>GitHub: GET /repos/:owner/:repo/issues/:number/comments (check marker)
    GitHub-->>Script: comments list
    alt marker not present and not dry-run
        Script->>GitHub: POST /repos/:owner/:repo/issues/:number/comments (mention selected reviewer)
        GitHub-->>Script: 201 Created (comment id)
        Script->>Reviewer: notify via comment mention
    else marker present or dry-run
        Script-->>Workflow: no-op or preview output
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR implements a workflow to request triage reviews for GFI/Beginner PRs, posts comments with triage member mentions, and extracts configurable variables; however, it uses .github/triage-reviewers.txt instead of the required .github/triage-members.txt file. Rename the triage member list file from triage-reviewers.txt to triage-members.txt as specified in issue #1721, or ensure the script uses the correct file path.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a workflow to review PRs labeled with GFI and Beginner.
Description check ✅ Passed The description is related to the changeset and references the linked issue #1721; it documents the workflow addition for triage review requests.
Out of Scope Changes check ✅ Passed All changes are in scope: workflow definition, triage bot script, and changelog entry directly support the issue #1721 requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 10

Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread CHANGELOG.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated

@aceppaluni aceppaluni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tech0priyanshu Thank you very much!

Was this tested on your fork?
Could we extract some of the logic into a sperate file (i.e .sh or .js)?

@github-actions

Copy link
Copy Markdown

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

  1. Click on the "Resolve conflicts" button in the PR
  2. Accept both changes (keep both changelog entries)
  3. Click "Mark as resolved"
  4. Commit the merge

For all other merge conflicts, please read:

Thank you for contributing!

@codecov

codecov Bot commented Feb 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         144      144           
  Lines        9350     9350           
=======================================
  Hits         8760     8760           
  Misses        590      590           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tech0priyanshu
tech0priyanshu force-pushed the feat/GFI_Beginner_triage branch from 0a34082 to 63cc81f Compare February 21, 2026 01:24

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
Comment thread .github/workflows/request-triage-review.yml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment thread .github/scripts/bot-pr-gfi-review-triage.sh Outdated
@tech0priyanshu
tech0priyanshu marked this pull request as draft February 21, 2026 02:33

@exploreriii exploreriii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tech0priyanshu
As this workflow is not urgent, we should focus on creating clean code that is as easy as possible to maintain in the future

May i suggest you switch this from bash to javascript, using github script action
This will mean less manual constructions and is less error prone
Then please focus on writing this with clear exits and logs

Additionally it is essential to research each package you will be using, and use the latest version
docs/sdk_developers/how-to-pin-github-actions.md

We have some guides now in
docs/workflows

@github-actions

Copy link
Copy Markdown

Hello, this is the OfficeHourBot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here for any changes.

From,
The Python SDK Team

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

Hi @tech0priyanshu,

This pull request has had no commit activity for 10 days. Are you still working on it?
To keep the PR active, you can:

  • Push a new commit.
  • Comment /working on the linked issue (not this PR).

If you're no longer working on this, please comment /unassign on the linked issue to release it for others. Otherwise, this PR may be closed due to inactivity.

Reach out on discord or join our office hours if you need assistance.

From the Python SDK Team

Comment thread .github/workflows/request-triage-review.yml
@tech0priyanshu

Copy link
Copy Markdown
Contributor Author

Yeah, I will resume my work after this. I have exams from Monday to Friday, so I’m busy revising for them.

@tech0priyanshu
tech0priyanshu force-pushed the feat/GFI_Beginner_triage branch from f22179e to 42b6c36 Compare March 17, 2026 01:53
@github-actions

Copy link
Copy Markdown

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@tech0priyanshu
tech0priyanshu marked this pull request as ready for review March 17, 2026 09:13
@tech0priyanshu
tech0priyanshu marked this pull request as draft March 17, 2026 09:48
@tech0priyanshu
tech0priyanshu force-pushed the feat/GFI_Beginner_triage branch 2 times, most recently from 5079f5d to 7c2c202 Compare March 17, 2026 23:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/request-triage-review.yml Outdated
@tech0priyanshu
tech0priyanshu marked this pull request as ready for review April 21, 2026 10:26
@tech0priyanshu

Copy link
Copy Markdown
Contributor Author

tech1priyanshu/test-#1

The above repository does not have access to self-hosted runners, so I used runs-on: ubuntu-latest during testing.

Additionally, to avoid spamming PR comments, the comment is posted only once when the label is present. Subsequent runs will skip posting. During the second review, the CODEOWNERS file already assigns the relevant reviewers once they are mentioned.

cc: @exploreriii

Comment thread .github/workflows/request-triage-review.yml
@exploreriii

Copy link
Copy Markdown
Contributor

Please could you also help to speed up the review process and resolve the conversations that are. Thanks

@exploreriii exploreriii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes due to inactive package

@exploreriii
exploreriii marked this pull request as draft April 21, 2026 16:12
@tech0priyanshu
tech0priyanshu force-pushed the feat/GFI_Beginner_triage branch from 5fe5551 to de3b421 Compare April 21, 2026 17:03
@codacy-production

codacy-production Bot commented Apr 21, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/request-triage-review.yml
@tech0priyanshu
tech0priyanshu marked this pull request as ready for review April 21, 2026 17:26
Comment thread .github/workflows/request-triage-review.yml Outdated
@aceppaluni

Copy link
Copy Markdown
Contributor

@tech0priyanshu Can you resolve the open conversations to help speed up review?

Thank you!

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

fix updated things

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

fix

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

fixs

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

log remove not needed

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

update

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

fix

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

fixs

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
@tech0priyanshu
tech0priyanshu force-pushed the feat/GFI_Beginner_triage branch from de3b421 to 6b30c56 Compare April 22, 2026 22:35
@tech0priyanshu

Copy link
Copy Markdown
Contributor Author

Comment thread .github/workflows/request-triage-review.yml
@exploreriii exploreriii added reviewer: write requires a review with write permissions step: 2nd second stage of the review approval process labels Apr 23, 2026
@exploreriii
exploreriii merged commit 7d3dfd1 into hiero-ledger:main Apr 24, 2026
11 checks passed
@exploreriii

Copy link
Copy Markdown
Contributor

Thanks @tech0priyanshu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewer: write requires a review with write permissions skill: intermediate requires some knowledge of the codebase with some defined steps to implement or examples step: 2nd second stage of the review approval process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Create a workflow for PRs labelled 'Good First Issue' or 'Beginner' to request review from triage

5 participants